clean-code-javascript

• 一个函数只做一件事

劣

function emailClients(clients) {
  clients.forEach(client => {
    const clientRecord = database.lookup(client);
    if (clientRecord.isActive()) {
      email(client);
    }
  });
}

优

function emailActiveClients(clients) {
  clients.filter(isActiveClient).forEach(email);
}

function isActiveClient(client) {
  const clientRecord = database.lookup(client);
  return clientRecord.isActive();
}

• 封装条件

劣

if ((a === 'yes' && !isEmpty(b)) || (c === 'ok')) {

}

优

function shouldCon(a, b, c) {
  return (a === 'yes' && !isEmpty(b)) || (c === 'ok')
}

if (shouldCon(a, b, c)) {}